Merge feature branch with master #119
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kallol Roy <karoy@progress.com>
Removing Sqllite3
Signed-off-by: Kallol Roy <karoy@progress.com>
…into add_request_validators
Signed-off-by: Kallol Roy <karoy@progress.com>
Signed-off-by: Kallol Roy <karoy@progress.com>
Signed-off-by: Kallol Roy <karoy@progress.com>
Signed-off-by: Kallol Roy <karoy@progress.com>
Signed-off-by: Abdul-Az <aazeez@progress.com>
Signed-off-by: Abdul-Az <aazeez@progress.com>
Signed-off-by: Abdul-Az <aazeez@progress.com>
Signed-off-by: Abdul-Az <aazeez@progress.com>
Signed-off-by: Abdul-Az <aazeez@progress.com>
Signed-off-by: Abdul-Az <aazeez@progress.com>
Signed-off-by: Abdul-Az <aazeez@progress.com>
Signed-off-by: Abdul-Az <aazeez@progress.com>
Signed-off-by: Abdul-Az <aazeez@progress.com>
Signed-off-by: Abdul-Az <aazeez@progress.com>
Signed-off-by: Abdul-Az <aazeez@progress.com>
Signed-off-by: Abdul-Az <aazeez@progress.com>
Signed-off-by: Abdul-Az <aazeez@progress.com>
Signed-off-by: Abdul-Az <aazeez@progress.com>
Signed-off-by: Abdul-Az <aazeez@progress.com>
Signed-off-by: Abdul-Az <aazeez@progress.com>
Signed-off-by: Abdul-Az <aazeez@progress.com>
Signed-off-by: Abdul-Az <aazeez@progress.com>
Signed-off-by: Abdul-Az <aazeez@progress.com>
' Signed-off-by: Abdul-Az <aazeez@progress.com>
Signed-off-by: Abdul-Az <aazeez@progress.com>
Signed-off-by: Abdul-Az <aazeez@progress.com>
Signed-off-by: Abdul-Az <aazeez@progress.com>
Signed-off-by: Abdul-Az <aazeez@progress.com>
Signed-off-by: Abdul-Az <aazeez@progress.com>
Signed-off-by: Abdul-Az <aazeez@progress.com>
Signed-off-by: Abdul-Az <aazeez@progress.com>
Signed-off-by: Abdul-Az <aazeez@progress.com>
Signed-off-by: Abdul-Az <aazeez@progress.com>
Signed-off-by: Abdul-Az <aazeez@progress.com>
Signed-off-by: Abdul-Az <aazeez@progress.com>
Signed-off-by: Abdul-Az <aazeez@progress.com>
Signed-off-by: Abdul-Az <aazeez@progress.com>
Signed-off-by: Abdul-Az <aazeez@progress.com>
Fixed errors occurred while testing
Signed-off-by: Abdul-Az <aazeez@progress.com>
Signed-off-by: Abdul-Az <aazeez@progress.com>
Ldap fix
* Testing Refresh API Signed-off-by: SanjuPal01 <sanju.sanju@progress.com> * Change 2 * Handler * Last Used * test * Time Difference * Check * Token Validator Signed-off-by: SanjuPal01 <sanju.sanju@progress.com> * Checking * Check * Test * Test * Check * Check * Check * Check * Check * Check * Check * Check * Check * Check * Check * Removing Redundant Code Signed-off-by: SanjuPal01 <sanju.sanju@progress.com> * Token Validator Signed-off-by: SanjuPal01 <sanju.sanju@progress.com> * Removing Redundant Code Signed-off-by: SanjuPal01 <sanju.sanju@progress.com> * Code Updated Signed-off-by: SanjuPal01 <sanju.sanju@progress.com> * Fixed validator Signed-off-by: SanjuPal01 <sanju.sanju@progress.com> * naming convention Signed-off-by: SanjuPal01 <sanju.sanju@progress.com>
Signed-off-by: Abdul-Az <aazeez@progress.com>
Signed-off-by: Abdul-Az <aazeez@progress.com>
|
Kudos, SonarCloud Quality Gate passed!
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| } | ||
|
|
||
| if err := s.storage.UpdateInvalidLoginAttempt(username, updater); err != nil { | ||
| s.logger.Errorf("Failed to reset invalid counter: %v", err) |
Check failure
Code scanning / CodeQL
Log entries created from user input
| } | ||
|
|
||
| if err := s.storage.UpdateInvalidLoginAttempt(username_conn_id, updater); err != nil { | ||
| s.logger.Errorf("Failed to increment invalid counter: %v", err) |
Check failure
Code scanning / CodeQL
Log entries created from user input
| //check if user is in invalid_login_attempts table | ||
| InvalidLoginAttempt, err = s.storage.GetInvalidLoginAttempt(username_conn_id) | ||
| if err != nil { | ||
| s.logger.Errorf("Failed to get InvalidLoginAttempt: %v", err) |
Check failure
Code scanning / CodeQL
Log entries created from user input
| redirectURL, err := s.finalizeLogin(identity, authReq, conn.Connector) | ||
| if err != nil { | ||
| s.logger.Errorf("Failed to finalize login: %v", err) | ||
| s.renderError(r, w, http.StatusInternalServerError, "Login error.") | ||
| return | ||
| } | ||
|
|
||
| if err := s.storage.DeleteInvalidLoginAttempt(username_conn_id); err != nil && err != storage.ErrNotFound { | ||
| s.logger.Errorf("Failed to delete InvalidLoginAttempt: %v", err) |
Check failure
Code scanning / CodeQL
Log entries created from user input
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
What this PR does / why we need it
resolved conflicts of add_invalid_attempts branch with master.
Latest changes by dex repo requires updated Go version of 1.19
We have to upgrade go version to 1.19 in automate for it to test with dex-1 master
Special notes for your reviewer
Does this PR introduce a user-facing change?