Move read_wstring method from chef to ffi-win32-extensions #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…f to ffi-win32-extensions Signed-off-by: Kapil Chouhan <kapil.chouhan@msystechnologies.com>
kapilchouhan99
force-pushed
the
Kapil/added_read_wstring_method
branch
from
3c29c81
to
14354fd
Compare
mwrock
approved these changes
Sep 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Kapil Chouhan kapil.chouhan@msystechnologies.com
Description
In order to fix this buildkite error we need to move
read_wstring,wide_to_utf8andread_utf16stringmethods fromcheftoffi-win32-extensions, so these methods are available for bothchefandmixlib-shelloutNote
After merging this PR, we need to create one more PR for removing these methods from the chef.