fix cli inherited profiles #1008
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chris-rock
force-pushed
the
vj/fix-cli-inherited-profiles
branch
from
805fa37
to
84c1ec3
Compare
|
@Vj this looks great. Can you fix the functional tests |
vjeffrey
force-pushed
the
vj/fix-cli-inherited-profiles
branch
from
84c1ec3
to
1ea7eac
Compare
vjeffrey
force-pushed
the
vj/fix-cli-inherited-profiles
branch
from
1ea7eac
to
5b18c42
Compare
vjeffrey
force-pushed
the
vj/fix-cli-inherited-profiles
branch
from
5b18c42
to
23e6a0c
Compare
|
running two profiles from command line: |
|
@chris-rock all fixed :) |
chris-rock
force-pushed
the
vj/fix-cli-inherited-profiles
branch
from
23e6a0c
to
0667c33
Compare
| @@ -164,10 +164,32 @@ def profile_info(profile) | |||
| [info[:name], info] | |||
| end | |||
|
|
|||
| # | |||
| # TODO(ssd+vj): We should probably solve this by either ensuring the example has | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is branched off the vj/fix-cli-report branch, so it needs to be rebased once that one merges. there's only one commit for this change, the fix inherited profile cli report commit
this fixes #898
run inherited profile with my fix commented out:
run inherited profile with my fix:
run inherited profile directly:
