Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable the json resource to accept command output or JSON content #1271

Merged
merged 4 commits into from
Nov 2, 2016

Conversation

jerearista
Copy link
Contributor

No description provided.

Signed-off-by: Jere Julian <jere@arista.com>
Signed-off-by: Jere Julian <jere@arista.com>
Signed-off-by: Jere Julian <jere@arista.com>
@chris-rock
Copy link
Contributor

Great improvement @jerearista

@@ -21,19 +30,28 @@ class JsonConfig < Inspec.resource(1)

def initialize(path)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we rename path to opts then? Its only a path if used as a string then

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed. Changed.

Signed-off-by: Jere Julian <jere@arista.com>
@chris-rock
Copy link
Contributor

Thanks @jerearista

@chris-rock chris-rock merged commit 408a180 into inspec:master Nov 2, 2016
webframp added a commit to webframp/inspec that referenced this pull request Jan 20, 2019
The `command` and `content` usage seems to have been supported for some time, but is not included in the documentation.

ref:
* inspec#1271
webframp added a commit to webframp/inspec that referenced this pull request Jan 20, 2019
The `command` and `content` usage seems to have been supported for some time, but is not included in the documentation.

ref:
* inspec#1271

Signed-off-by: Sean Escriva <sean.escriva@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants