fix file permission check by mask #1273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Christoph Hartmann <chris@lollyrock.com>
chris-rock
force-pushed
the
chris-rock/fix-file-permission
branch
from
a3e12f4
to
0eb9de0
Compare
|
cc @jeremymv2 |
|
👍 just tested it 🌟 |
|
@chris-rock This looks good and I concur that it tests ok locally. 👍 How was this passing integration tests??? |
|
Ahh - because it's not running: https://github.com/chef/inspec/blob/master/test/integration/default/file_spec.rb#L2-L5 |
|
@jeremymv2 I take care that we'll add most of the tests in docker. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #1264 and issues with dev-sec/chef-ssh-hardening#128