Support for OpenSuse Leap, new enterprise distro of SUSE #128

Merged
merged 2 commits into from Nov 4, 2016

Conversation

Projects
None yet
4 participants
@artem-sidorenko

This comment has been minimized.

Show comment
Hide comment
@artem-sidorenko

artem-sidorenko Oct 26, 2016

Member

Hm, suse testing is not included in the travis, so this issue was not catched. I will add it

Member

artem-sidorenko commented Oct 26, 2016

Hm, suse testing is not included in the travis, so this issue was not catched. I will add it

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Oct 26, 2016

Coverage Status

Coverage remained the same at 100.0% when pulling ae9444d on artem-sidorenko:opensuseleap into b8f5a06 on dev-sec:master.

Coverage Status

Coverage remained the same at 100.0% when pulling ae9444d on artem-sidorenko:opensuseleap into b8f5a06 on dev-sec:master.

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Oct 26, 2016

Coverage Status

Coverage remained the same at 100.0% when pulling f8b673a on artem-sidorenko:opensuseleap into b8f5a06 on dev-sec:master.

coveralls commented Oct 26, 2016

Coverage Status

Coverage remained the same at 100.0% when pulling f8b673a on artem-sidorenko:opensuseleap into b8f5a06 on dev-sec:master.

@artem-sidorenko

This comment has been minimized.

Show comment
Hide comment
@artem-sidorenko

artem-sidorenko Oct 26, 2016

Member

@chris-rock any idea about the timeout on suse testing on travis? I can not reproduce it locally :(

Member

artem-sidorenko commented Oct 26, 2016

@chris-rock any idea about the timeout on suse testing on travis? I can not reproduce it locally :(

@chris-rock

This comment has been minimized.

Show comment
Hide comment
@chris-rock

chris-rock Oct 26, 2016

Member

@artem-sidorenko Maybe we've an issue with the ssh config and suse does not let us in after hardening?

Member

chris-rock commented Oct 26, 2016

@artem-sidorenko Maybe we've an issue with the ssh config and suse does not let us in after hardening?

@atomic111

This comment has been minimized.

Show comment
Hide comment
@atomic111

atomic111 Oct 28, 2016

Member

@artem-sidorenko i restarted travis and it was working, but i get now 3 inspec failures

https://travis-ci.org/dev-sec/chef-ssh-hardening/jobs/170690452

Member

atomic111 commented Oct 28, 2016

@artem-sidorenko i restarted travis and it was working, but i get now 3 inspec failures

https://travis-ci.org/dev-sec/chef-ssh-hardening/jobs/170690452

@artem-sidorenko

This comment has been minimized.

Show comment
Hide comment
@artem-sidorenko

artem-sidorenko Oct 28, 2016

Member

@atomic111 thx, I see.

I'll have a look in the next days

Member

artem-sidorenko commented Oct 28, 2016

@atomic111 thx, I see.

I'll have a look in the next days

@chris-rock

This comment has been minimized.

Show comment
Hide comment
@chris-rock

chris-rock Oct 31, 2016

Member

Looks like file permissions for /etc/ssh/ssh_config, /etc/ssh and /etc/ssh/sshd_config are not properly configured.

Member

chris-rock commented Oct 31, 2016

Looks like file permissions for /etc/ssh/ssh_config, /etc/ssh and /etc/ssh/sshd_config are not properly configured.

@chris-rock

This comment has been minimized.

Show comment
Hide comment
@chris-rock

chris-rock Oct 31, 2016

Member

This looks like a bug in inspec in combination with SUSE. https://github.com/chef/inspec/blob/master/lib/resources/file.rb#L142-L143

Member

chris-rock commented Oct 31, 2016

This looks like a bug in inspec in combination with SUSE. https://github.com/chef/inspec/blob/master/lib/resources/file.rb#L142-L143

@chris-rock

This comment has been minimized.

Show comment
Hide comment
Member

chris-rock commented Oct 31, 2016

related to inspec/inspec#1264

@chris-rock chris-rock referenced this pull request in inspec/inspec Nov 3, 2016

Merged

fix file permission check by mask #1273

@chris-rock

This comment has been minimized.

Show comment
Hide comment
@chris-rock

chris-rock Nov 4, 2016

Member

Thanks @artem-sidorenko for adding opensuse leap to our integration test

Member

chris-rock commented Nov 4, 2016

Thanks @artem-sidorenko for adding opensuse leap to our integration test

@chris-rock chris-rock merged commit 2d11a0f into dev-sec:master Nov 4, 2016

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 100.0%
Details
@artem-sidorenko

This comment has been minimized.

Show comment
Hide comment
@artem-sidorenko

artem-sidorenko Nov 5, 2016

Member

@chris-rock @atomic111 just make something, fail to reproduce the issue, do not have time for further investigation - the problem gets resolved by itself (or other people), thats cool :D

Member

artem-sidorenko commented Nov 5, 2016

@chris-rock @atomic111 just make something, fail to reproduce the issue, do not have time for further investigation - the problem gets resolved by itself (or other people), thats cool :D

@artem-sidorenko artem-sidorenko deleted the artem-forks:opensuseleap branch Nov 5, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment