inspec check and json to use vendored dependencies #1321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alex Pop <apop@chef.io>
chris-rock
force-pushed
the
ap/check-vendor-cache
branch
2 times, most recently
from
4f51237
to
c9157af
Compare
Signed-off-by: Christoph Hartmann <chris@lollyrock.com>
chris-rock
force-pushed
the
ap/check-vendor-cache
branch
from
c9157af
to
5bfc974
Compare
alexpop
commented
Nov 29, 2016
| @@ -53,10 +61,51 @@ | |||
| out.stderr.must_equal '' | |||
| end | |||
|
|
|||
| it 'ensure json command is not fetching remote profiles if vendored' do | |||
There was a problem hiding this comment.
A good test for this would be to check that the vendored profile(ex: 01414bd307ea2f7d4dc8cd141085ba7ad61d4c3b2606d57b2dae987c1c3954cb.tar.gz was copied in the cache) instead of a remote one
There was a problem hiding this comment.
As in length is 1 and that profile is 01414bd307ea2f7d4dc8cd141085ba7ad61d4c3b2606d57b2dae987c1c3954cb.tar.gz
Signed-off-by: Christoph Hartmann <chris@lollyrock.com>
|
Awesome. Thank you @alexpop |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #1316 by providing a cache directory. Otherwise
copy_deps_into_cacheis not called.