Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show process name during inspec output #1329

Merged
merged 1 commit into from
Nov 29, 2016

Conversation

jcastillocano
Copy link
Contributor

Testing a process resource I got this output:

  Processes list.length
     ✔  should eq 1

when I expected something like Processes mysqld. Using grep variable to verify the output:

  Processes mysqld
     ✔  users should cmp == "mysql"

or, when we use RegExp:

  Processes /mysqld_safe/
     ✔  users should cmp == "root"

I also added some unit tests to verify this behavior.

@chris-rock
Copy link
Contributor

chris-rock commented Nov 29, 2016

@jcastillocano great addition. Could you squash your commits and rebase it to master? I propose you fetch latest master and call git rebase -i master from your branch. Let me know if you need any help.

Signed-off-by: Juan Carlos Castillo Cano <jccastillocano@gmail.com>
@jcastillocano jcastillocano reopened this Nov 29, 2016
@chris-rock chris-rock added the Type: Enhancement Improves an existing feature label Nov 29, 2016
@chris-rock
Copy link
Contributor

Thank you @jcastillocano for this contribution!

@chris-rock chris-rock merged commit 5d5be93 into inspec:master Nov 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement Improves an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants