Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

forgiving default attributes #2177

Merged
merged 2 commits into from
Sep 22, 2017
Merged

forgiving default attributes #2177

merged 2 commits into from
Sep 22, 2017

Conversation

arlimus
Copy link
Contributor

@arlimus arlimus commented Sep 22, 2017

When default attributes arent specified provide one that is much more forgiving.
See this #2176

@arlimus arlimus requested a review from a team as a code owner September 22, 2017 12:18
When default attributes arent specified provide one that is much more forgiving.
See this #2176

Signed-off-by: Dominik Richter <dominik.richter@gmail.com>
…ow...

Signed-off-by: Dominik Richter <dominik.richter@gmail.com>
Copy link
Contributor

@chris-rock chris-rock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thank you @adamleff and @arlimus

@adamleff adamleff added the Type: Enhancement Improves an existing feature label Sep 22, 2017
Copy link
Contributor

@adamleff adamleff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would I ever do this in another Ruby project on purpose? Nope. Do I think it's a great idea to provide a great user experience for our project? You bet!

Thanks, @arlimus!

@adamleff adamleff merged commit e2004a4 into master Sep 22, 2017
@adamleff adamleff deleted the dom/attribute-defaults branch September 22, 2017 12:57
@arlimus
Copy link
Contributor Author

arlimus commented Sep 22, 2017

ahahahaha thank you @adamleff

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement Improves an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants