Include ref when writing out inspec control objects #2259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arlimus
force-pushed
the
dom/object-ref
branch
from
99c8b58
to
0d2f515
Compare
Signed-off-by: Dominik Richter <dominik.richter@gmail.com>
arlimus
force-pushed
the
dom/object-ref
branch
from
0d2f515
to
a1c73cc
Compare
|
Just for rounding it out do we want to add 'remediation' which should fully flush out the object with respect to what is documented and supported. |
|
@aaronlippold that's outside the scope of this PR, which simply ensures that refs are properly output when writing out a control object to disk. Adding "remediation" as a first-class citizen to the DSL would warrant an RFC for discussion. Right now, "remediation" is used as an example of a ref key, but isn't part of the DSL. |
adamleff
changed the title
adamleff
approved these changes
Oct 24, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
just like tags for all auto-generation and api-driven development :)