Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rspec cli control summary to not uniq fails/skips #2362

Merged
merged 1 commit into from
Dec 5, 2017

Conversation

jquick
Copy link
Contributor

@jquick jquick commented Dec 1, 2017

This fixes #2361

This change removes the uniq limiter on fails and skips. This ensures the control summary output is accurate even if tests are the same.

Signed-off-by: Jared Quick jquick@chef.io

Signed-off-by: Jared Quick <jquick@chef.io>
@jquick jquick self-assigned this Dec 1, 2017
@jquick jquick requested a review from a team as a code owner December 1, 2017 21:36
@jquick jquick requested a review from adamleff December 1, 2017 21:40
Copy link
Contributor

@adamleff adamleff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing this, @jquick!

Copy link
Contributor

@arlimus arlimus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Jared! :)

@arlimus arlimus merged commit 0dc0e3b into master Dec 5, 2017
@arlimus arlimus deleted the jq/rspec_cli_control_summary_uniq branch December 5, 2017 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong control cli output when test are identical
3 participants