Sort library files before loading them so load order is predictable #2475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
adamleff
approved these changes
Jan 22, 2018
There was a problem hiding this comment.
This looks fine to me, but I'd like @arlimus or @chris-rock to chime in as they're more familiar with this part of the codebase and any potential unintended consequences of this change.
arlimus
approved these changes
Jan 22, 2018
There was a problem hiding this comment.
Thank you @clintoncwolfe this should make things more predictable!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2474
This is a one-line fix. I chose to make the change as close to the problem as possible to minimize impact. Unit tests and linter passed.