Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move AWS/Azure tests to integration directory #2675

Merged
merged 1 commit into from
Feb 26, 2018
Merged

Conversation

jerryaldrichiii
Copy link
Contributor

The AWS/Azure integration tests should live in the test/integration directory.

Signed-off-by: Jerry Aldrich <jerryaldrichiii@gmail.com>
@clintoncwolfe
Copy link
Contributor

clintoncwolfe commented Feb 20, 2018

Jerry, could you give your reasoning behind this? (Not opposed, just curious)

@jerryaldrichiii jerryaldrichiii added Aspect: Docs Write the Fine Manual and removed Aspect: Docs Write the Fine Manual labels Feb 23, 2018
@jerryaldrichiii
Copy link
Contributor Author

@clintoncwolfe apologies for the late response (forgot to hit comment apparently) 😓

Essentially, as a contributor, I expect these sort of tests to be in test/integration. Also, since the integration directory already exists I figured we might as well put these there to keep test/ more tidy.

Copy link
Contributor

@jquick jquick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jerryaldrichiii !

@jquick jquick merged commit d356cfc into master Feb 26, 2018
@jquick jquick deleted the ja/move-aws-azure-tests branch February 26, 2018 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants