Fix matcher output when the args to the matcher are a hash for two resources #3044
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2925
2925 indicated that reporters would output an empty hash when a matcher that accepted hash arguments was used. It turned out that works fine - it's just that two resources,
aws_iam_security_group
andaws_iam_policy
were both using Hash#delete to whitelist criteria in matchers, withoutdup
ing the Hash. So, if all went well, the input hash would be emptied; and the reporter would faithfully include an empty hash in the test description.This fix simply adds
dup
calls to the matcher hash arguments. To test, run the AWS integration tests and observe test output for the two affected resources.