Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: inheritance of local profiles #524

Merged
merged 2 commits into from
Mar 8, 2016
Merged

Conversation

arlimus
Copy link
Contributor

@arlimus arlimus commented Mar 8, 2016

This is just the start of a larger section of rework needed at this point. For now: just make it work with local inheritance again.

@arlimus arlimus added the Type: Bug Feature not working as expected label Mar 8, 2016
@arlimus arlimus self-assigned this Mar 8, 2016
@@ -6,11 +6,13 @@

module Inspec::DSL
def require_controls(id, &block)
::Inspec::DSL.load_spec_files_for_profile self, id, false, &block
opts = { profile_id: id, include_all: true, backend: @backend, conf: @conf }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that should be include_all false

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch, thank you!!

@arlimus arlimus force-pushed the dr/fix-inheritance branch 3 times, most recently from 7ac5158 to d445547 Compare March 8, 2016 12:59
@arlimus arlimus changed the title WIP bugfix: inheritance of local profiles bugfix: inheritance of local profiles Mar 8, 2016
@chris-rock
Copy link
Contributor

Thanks @arlimus one step forward :-)

chris-rock added a commit that referenced this pull request Mar 8, 2016
bugfix: inheritance of local profiles
@chris-rock chris-rock merged commit 139fa14 into master Mar 8, 2016
@chris-rock chris-rock deleted the dr/fix-inheritance branch March 8, 2016 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Feature not working as expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants