Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add title, description, code, and source_location to example metadata #543

Merged
merged 1 commit into from
Mar 17, 2016

Conversation

vjeffrey
Copy link

screen shot 2016-03-17 at 9 40 22 am

@@ -22,6 +22,10 @@ def format_example(example)
pending_message: example.execution_result.pending_message,
id: example.metadata[:id],
impact: example.metadata[:impact],
title: example.metadata[:title],
descr: example.metadata[:desc],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we use :desc instead of :descr?

@vjeffrey vjeffrey force-pushed the vj/add-title-desc-code-source-loc-to-metadata branch from 17afed8 to 3e90651 Compare March 17, 2016 10:07
@chris-rock
Copy link
Contributor

@vjeffrey +1 I like that implementation. Could we cover the title, desc in a separate object:

{
    ...
   metadata : {
      title: "abc",
      desc: ""
  }
}

@vjeffrey vjeffrey force-pushed the vj/add-title-desc-code-source-loc-to-metadata branch from 3e90651 to 2cae1fe Compare March 17, 2016 13:05
@vjeffrey vjeffrey force-pushed the vj/add-title-desc-code-source-loc-to-metadata branch from 2cae1fe to 8e4f677 Compare March 17, 2016 13:15
@arlimus arlimus force-pushed the vj/add-title-desc-code-source-loc-to-metadata branch from 8e4f677 to 08616f5 Compare March 17, 2016 14:23
@arlimus
Copy link
Contributor

arlimus commented Mar 17, 2016

Great point @chris-rock , let's move to a clean separate JSON format that combines inspec's fields and rspec's data to a proper report structure.

@arlimus
Copy link
Contributor

arlimus commented Mar 17, 2016

For now: flatten it out until we have another json reporter. Please don't use these fields here, they will go away!

arlimus added a commit that referenced this pull request Mar 17, 2016
…o-metadata

Add title, description, code, and source_location to example metadata
@arlimus arlimus merged commit 424d97c into master Mar 17, 2016
@arlimus arlimus deleted the vj/add-title-desc-code-source-loc-to-metadata branch March 17, 2016 14:32
@arlimus
Copy link
Contributor

arlimus commented Mar 19, 2016

Please not that this has been superseded by #552

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants