-
Notifications
You must be signed in to change notification settings - Fork 682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add title, description, code, and source_location to example metadata #543
Conversation
vjeffrey
commented
Mar 16, 2016
fa96bfd
to
17afed8
Compare
@@ -22,6 +22,10 @@ def format_example(example) | |||
pending_message: example.execution_result.pending_message, | |||
id: example.metadata[:id], | |||
impact: example.metadata[:impact], | |||
title: example.metadata[:title], | |||
descr: example.metadata[:desc], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we use :desc
instead of :descr
?
17afed8
to
3e90651
Compare
@vjeffrey +1 I like that implementation. Could we cover the
|
3e90651
to
2cae1fe
Compare
2cae1fe
to
8e4f677
Compare
8e4f677
to
08616f5
Compare
Great point @chris-rock , let's move to a clean separate JSON format that combines inspec's fields and rspec's data to a proper report structure. |
For now: flatten it out until we have another json reporter. Please don't use these fields here, they will go away! |
…o-metadata Add title, description, code, and source_location to example metadata
Please not that this has been superseded by #552 |