Passing bootstrap_ip_address as an array object instead of string #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wow, great find. I'll set up a release for |
jjasghar
pushed a commit
that referenced
this pull request
Feb 24, 2016
Passing bootstrap_ip_address as an array object instead of string
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for chef/knife-openstack#186 and #100
The issue was that
knife-windowsandchefare expectingbootstrap_ip_addressto be provided as an array which they try to split here https://github.com/chef/knife-windows/blob/master/lib/chef/knife/winrm_knife_base.rb#L69.This was being passed as a String earlier, hence taking only the first character of the IP address.