Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit hostnames to 15 characters (for windows) #81

Merged
merged 1 commit into from
Sep 19, 2014

Conversation

hh
Copy link

@hh hh commented Sep 9, 2014

When trying to use knife-cloud based plugins, the default node name generation is more than 15 characters which gives windows boxes a hard time. This patch limits the names to 15 characters.
/cc @mattray @taylor @vulk

@btm
Copy link
Contributor

btm commented Sep 9, 2014

Can you expand on the "hard time" part? It would be surprising if old NETBIOS name constraints weren't easily worked around. /cc @opscode/platform-engineering

mattray added a commit that referenced this pull request Sep 19, 2014
Limit hostnames to 15 characters (for windows)
@mattray mattray merged commit 834385e into chef:master Sep 19, 2014
@mattray
Copy link
Contributor

mattray commented Sep 19, 2014

knife-vcair needs this for Windows to work, there may be work arounds to fix this properly, but this is an edge case that I doubt will get much attention.

@adamedx
Copy link

adamedx commented Sep 19, 2014

The workaround for netbios limitations is fqdn's -- the DNS name for a Windows system may be long (well, as long as the RFC for DNS names allows I guess). But the legacy "computername" which we think of as hostname has to be less than 16 characters -- typically that computername is the leading component of the DNS name. More here: http://support.microsoft.com/kb/909264.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants