Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for Generate temporary keypair when none is supplied #608

Merged

Conversation

@kapilchouhan99
Copy link
Contributor

commented Aug 29, 2019

Signed-off-by: Kapil Chouhan kapil.chouhan@msystechnologies.com

Description

  • Added a method create_key_pair to generate a keypair when provisioning a host if no Key Pair name is given
  • Added test cases
  • Ensured chef-style on the code changes made

Issues Resolved

Fixes #457

Check List

Signed-off-by: Kapil Chouhan <kapil.chouhan@msystechnologies.com>
@kapilchouhan99 kapilchouhan99 changed the title Fix for Generate temporary keypair when none is supplied [WIP] Fix for Generate temporary keypair when none is supplied Aug 30, 2019
@kapilchouhan99 kapilchouhan99 changed the title [WIP] Fix for Generate temporary keypair when none is supplied Fix for Generate temporary keypair when none is supplied Sep 3, 2019
@dheerajd-msys dheerajd-msys requested a review from tas50 Sep 10, 2019
Copy link
Contributor

left a comment

LGTM 👍

@tas50 tas50 merged commit dc9bbb3 into master Sep 15, 2019
3 checks passed
3 checks passed
DCO This commit has a DCO Signed-off-by
Details
buildkite/chef-knife-ec2-master-verify Build #51 passed (2 minutes, 24 seconds)
Details
expeditor/config-validation Validated your Expeditor config file
Details
@chef-expeditor chef-expeditor bot deleted the Kapil/MSYS-447_Generate_temporary_keypair_when_none_is_supplied branch Sep 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.