Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for Generate temporary keypair when none is supplied #608

Merged

Conversation

kapilchouhan99
Copy link

Signed-off-by: Kapil Chouhan kapil.chouhan@msystechnologies.com

Description

  • Added a method create_key_pair to generate a keypair when provisioning a host if no Key Pair name is given
  • Added test cases
  • Ensured chef-style on the code changes made

Issues Resolved

Fixes #457

Check List

Signed-off-by: Kapil Chouhan <kapil.chouhan@msystechnologies.com>
@kapilchouhan99 kapilchouhan99 changed the title Fix for Generate temporary keypair when none is supplied [WIP] Fix for Generate temporary keypair when none is supplied Aug 30, 2019
@kapilchouhan99 kapilchouhan99 changed the title [WIP] Fix for Generate temporary keypair when none is supplied Fix for Generate temporary keypair when none is supplied Sep 3, 2019
Copy link
Contributor

@dheerajd-msys dheerajd-msys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@tas50 tas50 merged commit dc9bbb3 into master Sep 15, 2019
@chef-expeditor chef-expeditor bot deleted the Kapil/MSYS-447_Generate_temporary_keypair_when_none_is_supplied branch September 15, 2019 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generate temporary keypair when none is supplied
4 participants