-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[KNIFE-231] and [KNIFE-277] workaround #30
[KNIFE-231] and [KNIFE-277] workaround #30
Conversation
…lable address if an interface with the specifid name is not found.
Hey @baylisscg! Thank you for supporting this Opscode knife plugin! Our process has a couple prerequisites before we can merge your contribution. We need to ensure you've completed a Contributor License Agreement (CLA) and a ticket on our ticket tracker for the release workflow. I looked, but I could not find one under your name. Pull requests are optional, but should always include the ticket number that they're related to for cross-referencing. Please take a moment to review the below wiki page for the appropriate steps:
Please feel free to ping me if you have any questions 😄 |
Hi @sethvargo all the CLA stuff is resolved and I think I've done the right things. |
Hey Chris, I'm on my mobile device and cannot check, but please make sure you mark the JIRA ticket as "Fix Provided". That tells the team your ticket is ready for review :) If you already did this, great! This message was sent from my mobile device. I apologize in advance for any typographical errors or autocorrections.
|
While this will work as a stop-gap solution, we are working on a more robust technique of passing in the name of the network you wish to use. I'll leave the PR open until that is released, but it's not being ignored. |
It seems that the openstack cluster I just got from Rackspace came with "Floating" and "Fixed" network names. This fix would have resolved me having to delete and rename-build the networks with "Public" and "Private." It seems now, I can spin machines up, but the |
Any progress here? This seems to be a showstopper! |
@runningman84 I created #80 and this has the most up to date information. I think we are waiting for |
Well, knife-cloud is all great, but why are we waiting on it to merge something to knife-openstack? This makes knife-openstack unusable for (most) installations. |
We're not waiting on knife-cloud, see my comment on KNIFE-231 for a longer explanation if you haven't yet. |
In case anyone here isn't following KNIFE-231, Matt has written an RFC for how he's fixing this, please make sure it covers your use case: https://github.com/mattray/chef-rfc/blob/openstack-network/rfc003-openstack-network.md |
Fix included in 0.9.0. |
Changed address fetching code to fall back to grabbing the first available address if an interface with the specified name is not found. This prevents knife from throwing an exception if none of the networks are called either "private" or "public".
I'm in the situation where are multiple Openstack cells, the network in each is named differently and I can't control which cell my VM is started in so being able to specify the network name doesn't help.