Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[KNIFE-435] Added parameter --user-data for cloud-init payload #82

Merged
merged 1 commit into from Mar 7, 2014

Conversation

ghost
Copy link

@ghost ghost commented Jan 16, 2014

This addresses ticket KNIFE-435

@btm
Copy link
Contributor

btm commented Feb 27, 2014

Thank you for taking the time to help make Chef better! We require a Contributor License Agreement (CLA) from contributors to help protect all Chef users. It is easy to complete one online. Instructions to do so are on our wiki, which is linked below. Once your account is updated, you will have access to 'resolve' tickets that indicates to the code review team that your contribution is ready for review.

http://wiki.opscode.com/display/chef/How+to+Contribute
http://wiki.opscode.com/display/chef/Code+Review

@ghost
Copy link
Author

ghost commented Mar 5, 2014

Hi Brian,

as far as I know our company "adesso mobile solutions GmbH" filled out a Contributor License Agreement.

Greets,
Andreas

@btm
Copy link
Contributor

btm commented Mar 6, 2014

Yes, I see you listed on the approved contributors list. When your email address on your JIRA account doesn't match what your company provides we can't update your account when we receive the CCLA, but I've updated your JIRA account accordingly. Yves Vogl from your company doesn't appear to have an account associated with your company either, although I think I see a personal account. Could you have Yves email me at btm@getchef.com with their username on http://tickets.opscode.com?

You can now set a ticket as "fix provided" when you would like Chef to review your contribution. We will take a look at this pull request right now too.

@adamedx
Copy link

adamedx commented Mar 6, 2014

@thielena , thank you for the contribution! User data is extremely useful in analogous plug-ins, so great to see it for openstack.

@adamedx
Copy link

adamedx commented Mar 6, 2014

@thielena , this looks good modulo the issue with the short option, but can you also add unit tests that validate that the new option is set correctly when specified? This will help us avoid regressions.

@lxndrp
Copy link

lxndrp commented Mar 7, 2014

@btm Yves Vogl left the company effective February 1, 2014. Do we need to update the CLA re: this change?

-Alexander

@btm
Copy link
Contributor

btm commented Mar 7, 2014

@lxndrp It's okay, shouldn't need to do anything.

@mattray mattray merged commit 99c56e5 into chef:master Mar 7, 2014
@tas50 tas50 added Type: Enhancement Adds new functionality. and removed Enhancement labels Jul 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement Adds new functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants