Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handling of config values for Chef 16 and fix undefined method downcase for nil:NilClass #51

Merged
merged 2 commits into from
Aug 7, 2020
Merged

Handling of config values for Chef 16 and fix undefined method downcase for nil:NilClass #51

merged 2 commits into from
Aug 7, 2020

Conversation

kapilchouhan99
Copy link

@kapilchouhan99 kapilchouhan99 commented Jul 20, 2020 •
edited
Loading

Signed-off-by: Kapil Chouhan kapil.chouhan@msystechnologies.com

Description

  • Handling the config values for Chef 16
  • Fixed NilClass error
  • Ensured chef-style on the code changes made

Related Issue

Fixes: #44

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

  • I have read the CONTRIBUTING document.
  • I have run the pre-merge tests locally and they pass.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • All commits have been signed-off for the Developer Certificate of Origin.

Fix for: undefined method downcase for nil:NilClass
6f87f60 
Signed-off-by: Kapil Chouhan <kapil.chouhan@msystechnologies.com>
@kapilchouhan99 kapilchouhan99 force-pushed the Kapil/Github-44_undefined_method_downcase_executing_catalog_list branch from c485e45 to 6f87f60 Compare July 20, 2020 10:42
@tas50
Copy link
Contributor

tas50 commented Jul 20, 2020

@kapilchouhan99 This plugin is going to need to be updated for the config changes in Chef 16. Check the ruby 2.7 unit tests. They're very very red and that's valid.

@kapilchouhan99 kapilchouhan99 changed the title Fix for: undefined method downcase for nil:NilClass Handling of config values for Chef 16 and fix undefined method downcase for nil:NilClass Jul 23, 2020
Fix for handling of config values for Chef 16
57fec4a 
Signed-off-by: Kapil Chouhan <kapil.chouhan@msystechnologies.com>
@kapilchouhan99 kapilchouhan99 force-pushed the Kapil/Github-44_undefined_method_downcase_executing_catalog_list branch from 6b504b3 to 57fec4a Compare July 24, 2020 07:13
@dheerajd-msys dheerajd-msys requested a review from tas50 July 24, 2020 07:16
@tas50 tas50 added the Expeditor: Bump Version Major Used by github.major_bump_labels to bump the Major version number. label Aug 7, 2020
@tas50 tas50 merged commit 99be199 into master Aug 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tas50 tas50 Awaiting requested review from tas50

Assignees
No one assigned
Labels
Expeditor: Bump Version Major Used by github.major_bump_labels to bump the Major version number.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

FATAL: Unknown resource error : undefined method `downcase' executing catalog list
2 participants
@kapilchouhan99 @tas50