fix uninitialized constant Chef::Knife::Cloud::VraServerCreate::VraServiceHelpers #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rviceHelpers Signed-off-by: mwrock <matt@mattwrock.com>
phiggins
approved these changes
Oct 21, 2020
tas50
reviewed
Oct 21, 2020
| include VraServiceOptions | ||
| include ServerCreateOptions | ||
| include VraServiceHelpers |
There was a problem hiding this comment.
If you can make it work by putting the require and the include in the deps block you won't take the penalty of loading that code every time you run any old knife command.
There was a problem hiding this comment.
That was my first attempt but it blew up several tests that call validate_params! directly which does not trigger the deps block.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #53
Signed-off-by: mwrock matt@mattwrock.com