Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

INFCT-76 Updated the vmware-vra gem dependency and added support for Ruby 3.0 and 3.1 #62

Merged
merged 3 commits into from
May 18, 2022
Merged

INFCT-76 Updated the vmware-vra gem dependency and added support for Ruby 3.0 and 3.1 #62

merged 3 commits into from
May 18, 2022

Conversation

ashiqueps
Copy link
Contributor

@ashiqueps ashiqueps commented May 16, 2022 •
edited
Loading

Signed-off-by: Ashique Saidalavi ashique.saidalavi@progress.com

Description

Version 3 and above of the vmware-vra gem requires the vRA 8.x. This version currently supports version 7.x. This PR is to update the dependency. Support for 8.x will be added in a separate PR.

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

  • I have read the CONTRIBUTING document.
  • I have run the pre-merge tests locally and they pass.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • All commits have been signed-off for the Developer Certificate of Origin.

@ashiqueps
Updated the vmware-vra gem dependency
d70e478 
Signed-off-by: Ashique Saidalavi <ashique.saidalavi@progress.com>
@ashiqueps ashiqueps changed the title Updated the vmware-vra gem dependency INFCT-76 Updated the vmware-vra gem dependency May 16, 2022
@ashiqueps ashiqueps mentioned this pull request May 17, 2022
Merged
4 tasks
@ashiqueps
Fixed the typo
d4572d7 
Signed-off-by: Ashique Saidalavi <ashique.saidalavi@progress.com>
@ashiqueps
Added support for ruby 3.0 and 3.1
1b293e1 
Signed-off-by: Ashique Saidalavi <ashique.saidalavi@progress.com>
@sonarcloud
Copy link

sonarcloud bot commented May 17, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@ashiqueps ashiqueps changed the title INFCT-76 Updated the vmware-vra gem dependency INFCT-76 Updated the vmware-vra gem dependency and added support for Ruby 3.0 and 3.1 May 17, 2022
@kasif-adnan kasif-adnan merged commit 500ad97 into chef:main May 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@i5pranay93 i5pranay93 i5pranay93 approved these changes

@sanjain-progress sanjain-progress sanjain-progress approved these changes

@kasif-adnan kasif-adnan kasif-adnan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ashiqueps @i5pranay93 @sanjain-progress @kasif-adnan