Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

INFCT-76 - Updated the plugin to support vRA 8 #63

Merged
merged 9 commits into from
May 19, 2022
Merged

INFCT-76 - Updated the plugin to support vRA 8 #63

merged 9 commits into from
May 19, 2022

Conversation

ashiqueps
Copy link
Contributor

@ashiqueps ashiqueps commented May 16, 2022 •
edited
Loading

Description

This knife plugin currently supports the vRA 7.x only. This PR adds the support for using this plugin with the vRA 8.x server.

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

  • I have read the CONTRIBUTING document.
  • I have run the pre-merge tests locally and they pass.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • All commits have been signed-off for the Developer Certificate of Origin.

@ashiqueps
Added support for vRA 8.x
b49e7c6 
Signed-off-by: Ashique Saidalavi <ashique.saidalavi@progress.com>
@ashiqueps
Updated the documentation
d14dfbc 
Signed-off-by: Ashique Saidalavi <ashique.saidalavi@progress.com>
@ashiqueps
Docs update
b664410 
Signed-off-by: Ashique Saidalavi <ashique.saidalavi@progress.com>
@ashiqueps
Merge branch 'main' of github.com:chef/knife-vrealize into INFCT-76-v…
057a354 
…ra8-updates

Signed-off-by: Ashique Saidalavi <ashique.saidalavi@progress.com>
@ashiqueps
Fixed the style issues
0694ac0 
Signed-off-by: Ashique Saidalavi <ashique.saidalavi@progress.com>
@ashiqueps
Fixed the spec failures
c0490a6 
Signed-off-by: Ashique Saidalavi <ashique.saidalavi@progress.com>
@ashiqueps ashiqueps requested review from a team May 18, 2022 19:07
@ashiqueps
Updated the documentation
8d14275 
Signed-off-by: Ashique Saidalavi <ashique.saidalavi@progress.com>
kasif-adnan
kasif-adnan requested changes May 19, 2022
View reviewed changes
README.md Outdated Show resolved Hide resolved
lib/chef/knife/vra_server_create.rb Outdated Show resolved Hide resolved
@ashiqueps
Fixed the typo
24c0bee 
Signed-off-by: Ashique Saidalavi <ashique.saidalavi@progress.com>
@ashiqueps
Updated the argument description
738b555 
Signed-off-by: Ashique Saidalavi <ashique.saidalavi@progress.com>
@sonarcloud
Copy link

sonarcloud bot commented May 19, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot E 1 Security Hotspot
Code Smell A 10 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ashiqueps ashiqueps added Expeditor: Bump Version Major Used by github.major_bump_labels to bump the Major version number. Platform: VMware labels May 19, 2022
@kasif-adnan kasif-adnan merged commit 1e8bb93 into chef:main May 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanjain-progress sanjain-progress sanjain-progress approved these changes

@kasif-adnan kasif-adnan kasif-adnan approved these changes

Assignees
No one assigned
Labels
Expeditor: Bump Version Major Used by github.major_bump_labels to bump the Major version number. Platform: VMware
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ashiqueps @sanjain-progress @kasif-adnan