Improve the speed of finding an individual VM #422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Mar 15, 2018
lib/chef/knife/search_helper.rb
Outdated
| end | ||
|
|
||
| def get_vm_by_name(vmname) | ||
| vm = get_all_vm_objects.find { |r| r['name'] == vmname } |
lib/chef/knife/search_helper.rb
Outdated
| )] | ||
| ], | ||
| propSet: [ | ||
| { type: 'VirtualMachine', pathSet: properties} |
lib/chef/knife/search_helper.rb
Outdated
| type: 'ContainerView', | ||
| path: 'view', | ||
| skip: false | ||
| )] |
There was a problem hiding this comment.
Closing array brace must be on the line after the last array element when opening brace is on a separate line from the first array element.
lib/chef/knife/search_helper.rb
Outdated
| name: 'traverseEntities', | ||
| type: 'ContainerView', | ||
| path: 'view', | ||
| skip: false |
lib/chef/knife/search_helper.rb
Outdated
| type: ['VirtualMachine'], | ||
| recursive: true) | ||
|
|
||
| filterSpec = RbVmomi::VIM.PropertyFilterSpec( |
There was a problem hiding this comment.
Use snake_case for variable names.
lib/chef/knife/search_helper.rb
Outdated
| def get_all_vm_objects(properties = ['name']) | ||
| pc = vim_connection.serviceInstance.content.propertyCollector | ||
| viewmgr = vim_connection.serviceInstance.content.viewManager | ||
| rootFolder = vim_connection.serviceInstance.content.rootFolder |
There was a problem hiding this comment.
Use snake_case for variable names.
lib/chef/knife/search_helper.rb
Outdated
| @@ -0,0 +1,41 @@ | |||
| # Some helpers for faster searching of the inventory | |||
| module SearchHelper | |||
|
|
|||
There was a problem hiding this comment.
Extra empty line detected at module body beginning.
This PR makes use of the [ContainerView](https://www.vmware.com/support/developer/vc-sdk/visdk41pubs/ApiReference/vim.view.ViewManager.html) to retrieve a cut down list of servers from which the desired object can be found, after which the object itself can be downloaded. Previously, we'd download each VM (about 3.5K and several round trips to the server) to find the VM we want. From ``` sean~/play/knife-vsphere (find_speed %)$ time knife vsphere vm disk list myserver 0 Hard disk 1 nosnapshots_ds4 64.00 GiB real 1m56.153s user 0m9.536s sys 0m1.713s ``` to ``` sean~/play/knife-vsphere (find_speed *%)$ time be knife vsphere vm disk list myserver /Users/sean/.gem/ruby/2.4.1/gems/builder-3.2.2/lib/builder/xchar.rb:111: warning: constant ::Fixnum is deprecated 0 Hard disk 1 nosnapshots_ds4 64.00 GiB real 0m2.929s user 0m1.038s sys 0m0.236s ``` This'll have to be retrofitted to the other commands, which we can do over time. See vmware-archive/rbvmomi#117 for some more context
|
🤘 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes use of the
ContainerView
to retrieve a cut down list of servers from which the desired object can
be found, after which the object itself can be downloaded. Previously,
we'd download each VM (about 3.5K and several round trips to the server)
to find the VM we want.
From
to
This'll have to be retrofitted to the other commands, which we can do
over time.
See vmware-archive/rbvmomi#117 for some more context
Description
Issues Resolved
Check List