[JEX-327] Artifacts may exist in multiple current channel repos #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Seth Chisamore <schisamo@chef.io>
jaymalasinha
approved these changes
Sep 21, 2016
scotthain
approved these changes
Sep 21, 2016
rhass
suggested changes
Sep 21, 2016
| @@ -88,7 +88,7 @@ def promote(response) | |||
| end | |||
|
|
|||
| # Validate the artifacts all exist in `omnibus-current-local` | |||
There was a problem hiding this comment.
Minor detail, but we should update the comment to reflect this change.
Now that we have deployed APT/YUM repos in Artifactory (see JEX-186, JEX-187) we need to relax our current channel validation check to allow a builds's artifacts to exist in any of the following repos: * omnibus-current-local - The existing generic repo * current-apt-local - The new APT repo * current-yum-local - The new YUM repo * current-migration-local - Temp repo used for migrating to new APT/YUM repos Signed-off-by: Seth Chisamore <schisamo@chef.io>
This will save confusion. Signed-off-by: Seth Chisamore <schisamo@chef.io>
schisamo
force-pushed
the
schisamo/JEX-327-promotion-fixes
branch
from
39ef517
to
40739ed
Compare
rhass
approved these changes
Sep 21, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we have deployed APT/YUM repos in Artifactory (see JEX-186, JEX-187) we need to relax our current channel validation check to allow a builds's artifacts to exist in any of the following repos:
Signed-off-by: Seth Chisamore schisamo@chef.io
/cc @chef/engineering-services