mixlib-versioning backwards compatability for PartialSemVer support #229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhass
approved these changes
Aug 2, 2017
scotthain
approved these changes
Aug 2, 2017
lib/mixlib/install/options.rb
Outdated
| # If PartialSemVer is defined than the version of mixlib-versioning loaded can parse partial versions | ||
| # Otherwise parsing a partial version will return nil | ||
| is_partial = if defined?(Mixlib::Versioning::Format::PartialSemVer) | ||
| # remove if there's a trailing period for mixlib-versioning compatability |
Signed-off-by: Patrick Wright <patrick@chef.io>
Signed-off-by: Seth Chisamore <schisamo@chef.io>
Signed-off-by: Seth Chisamore <schisamo@chef.io>
schisamo
force-pushed
the
pw/mixlib-ver-1.2.2
branch
from
0858f1c
to
fca43f3
Compare
tduffield
approved these changes
Aug 2, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update mixlib-install to support mixlib-versioning's new partial semver support if available.
@schisamo @chef/engineering-services
Signed-off-by: Patrick Wright patrick@chef.io