Adding TLS negotiation support for older versions of .NET #254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andy-dufour
force-pushed
the
ad/ps_tls12_fix
branch
from
c5b091e
to
17fd573
Compare
|
Pinged the wrong people! @schisamo can you help find someone to review this? |
|
@andy-dufour I'm testing this out on a couple of platforms and then should be in a position to approve! Stand by! |
stuartpreston
approved these changes
May 1, 2018
rhass
suggested changes
May 8, 2018
| @@ -1,4 +1,5 @@ | |||
| [Console]::OutputEncoding = New-Object -typename System.Text.ASCIIEncoding | |||
| [System.Net.ServicePointManager]::SecurityProtocol = [System.Net.SecurityProtocolType]'Ssl3,Tls,Tls11,Tls12' | |||
There was a problem hiding this comment.
I am not sure if older versions of Windows natively support TLS 1.2 or not... but if they do, it should be the only TLS version we use. At the very least we should disable SSLv3, and possibly TLS 1.0.
andy-dufour
force-pushed
the
ad/ps_tls12_fix
branch
from
beebbfb
to
94ead38
Compare
added 2 commits
May 10, 2018 19:16
Signed-off-by: Andrew Dufour <adufour@chef.io>
Signed-off-by: Andrew Dufour <adufour@chef.io>
andy-dufour
force-pushed
the
ad/ps_tls12_fix
branch
from
94ead38
to
566cb86
Compare
schisamo
approved these changes
May 10, 2018
rhass
approved these changes
May 10, 2018
tas50
added
Expeditor: Bump Version Minor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should allow older verisons of .NET that are on operating systems forced to negotiate TLS 1.2 to successfully download our software using mixlib-install.
Corrects #253