Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update install scripts to not mention Omnibus #271

Merged
merged 1 commit into from
Nov 16, 2018
Merged

Update install scripts to not mention Omnibus #271

merged 1 commit into from
Nov 16, 2018

Conversation

tas50
Copy link
Contributor

@tas50 tas50 commented Nov 7, 2018

We've scrubbed the docs site for the term omnibus since it doesn't mean
anything out of Chef. This will help us to scrub it from every Test
Kitchen run.

Signed-off-by: Tim Smith tsmith@chef.io

We've scrubbed the docs site for the term omnibus since it doesn't mean
anything out of Chef. This will help us to scrub it from every Test
Kitchen run.

Signed-off-by: Tim Smith <tsmith@chef.io>
@tas50 tas50 requested a review from a team as a code owner November 7, 2018 22:46
Copy link
Contributor

@schisamo schisamo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we should update the wording in all of these messages to be a little more generic...these scripts are used to install all of Chef Software Inc's products.

@tas50
Copy link
Contributor Author

tas50 commented Nov 8, 2018

I'm open to improved wording that takes into account the product we're trying to install, but overall I think this is a solid improvement for now.

@tas50 tas50 merged commit affab28 into master Nov 16, 2018
@chef-ci chef-ci deleted the omnibus branch November 16, 2018 01:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants