Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for armv7l #279

Merged
merged 1 commit into from
Apr 15, 2019
Merged

Add support for armv7l #279

merged 1 commit into from
Apr 15, 2019

Conversation

LocutusOfBorg
Copy link
Contributor

Add also armv7l support
it looks like it makes the testsuite pass on Ubuntu armhf builders...

@LocutusOfBorg LocutusOfBorg requested a review from a team as a code owner April 15, 2019 15:53
Add also armv7l support

Signed-off-by: Gianfranco Costamagna <costamagnagianfranco@yahoo.it>
@schisamo
Copy link
Contributor

@LocutusOfBorg We don't currently produce any arm builds for Ubuntu so I'm a little confused on what y'all are trying to accomplish with this change.

@LocutusOfBorg
Copy link
Contributor Author

We (Debian and Ubuntu), provide this library in our repository
https://launchpad.net/ubuntu/+source/ruby-mixlib-install
https://packages.qa.debian.org/r/ruby-mixlib-install.html
and we run the testsuite on each architecture.
In this case, your package testsuite, stopped working on armhf after some releases (probably because new implemented tests)
http://autopkgtest.ubuntu.com/packages/r/ruby-mixlib-install/disco/armhf

This pull request tries to make it work and pass on this architecture too

@schisamo
Copy link
Contributor

@LocutusOfBorg Thanks for the context, sounds like a reasonable change (thank you).

@schisamo schisamo merged commit 1ec3562 into chef:master Apr 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants