Properly identify Windows 2019 in the install.ps1 #301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Right now we're identifying Windows 2019 systems as being 2016. This isn't a critical issue as our 2016 and 2019 packages are actually the same thing, but it would be good to properly identify the OS we're on. At the very least this gets us better usage data for Windows releases. The unfortunate thing is that Microsoft hasn't bumped the NT major or minor versionns for 2019. Instead they just pumped the patch (build) of the release. 2016 is 14xxx and 2019 is 17xxx. Last match wins in these switch statements so if we see a 17xxx build then identify it as 2019. 18000 is Windows 10 so I don't see them releasing a 2019 build that is in the 18000 range. If they do for some reason we'll identify these as 2016, which would be fine. I think that's the overly cautious route to take unless someone has concerns. Signed-off-by: Tim Smith <tsmith@chef.io>
marcparadise
approved these changes
Dec 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now we're identifying Windows 2019 systems as being 2016. This isn't a critical issue as our 2016 and 2019 packages are actually the same thing, but it would be good to properly identify the OS we're on. At the very least this gets us better usage data for Windows releases. The unfortunate thing is that Microsoft hasn't bumped the NT major or minor versions for 2019. Instead, they just pumped the patch (build) of the release. 2016 is 14xxx and 2019 is 17xxx. The last match wins in these switch statements so if we see a 17xxx build then identify it as 2019. 18000 is Windows 10 so I don't see them releasing a 2019 build that is in the 18000 range. If they do for some reason we'll identify these as 2016, which would be fine. I think that's the overly cautious route to take unless someone has concerns.
Signed-off-by: Tim Smith tsmith@chef.io