Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strip query parameters before parsing URI path #358

Merged
merged 2 commits into from
May 5, 2021

Conversation

gscho
Copy link
Contributor

@gscho gscho commented Apr 16, 2021

Description

The previously submitted solution breaks when there is a / in an auth token. This time we first remove everything after the first encountered ? and then parse the last item in the URI's path.

Related Issue

N/A

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

  • I have read the CONTRIBUTING document.
  • I have run the pre-merge tests locally and they pass.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • All commits have been signed-off for the Developer Certificate of Origin.

Signed-off-by: gscho <greg.c.schofield@gmail.com>
@gscho gscho requested review from a team as code owners April 16, 2021 20:47
@tduffield tduffield merged commit df795eb into chef:master May 5, 2021
@gscho gscho deleted the strip-query-params branch May 6, 2021 01:02
@jeremy-clerc
Copy link
Contributor

Hello,
Could you tell me how you tested this new sed / the url you are trying to strip ? So I can try to fix it and make it work with your use case while not breaking kitchen cf #368.

Thanks

@jeremy-clerc
Copy link
Contributor

Ok I think it is the ` that is in the wrong place

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants