Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update install script warning to not mention desktop #366

Merged
merged 1 commit into from
Aug 13, 2021

Conversation

rishichawda
Copy link
Member

Signed-off-by: rishichawda rishichawda@users.noreply.github.com

Description

Removed desktop from the list of environments where installing chef without version constraints should be fine. Desktop environments should also pin chef to a specific version.

Related Issue

resolve #365

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

  • I have read the CONTRIBUTING document.
  • I have run the pre-merge tests locally and they pass.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • All commits have been signed-off for the Developer Certificate of Origin.

@rishichawda rishichawda requested review from a team as code owners August 12, 2021 06:48
@tas50
Copy link
Contributor

tas50 commented Aug 12, 2021

@rishichawda Can you take a look at the spec failures. Right now it looks like contracts is requiring ruby 3. We're going to need to pin to < 0.17 there to prevent gem install failures

@tas50
Copy link
Contributor

tas50 commented Aug 13, 2021

@rishichawda can you rebase this now?

Signed-off-by: rishichawda <rishichawda@users.noreply.github.com>
@tas50 tas50 changed the title update warning to not include desktop Update install script warning to not mention desktop Aug 13, 2021
@tas50 tas50 merged commit c63df74 into chef:master Aug 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Should we recommend not pinning chef version on Desktop?
2 participants