Remove support for versions of ruby prior to 2.6 #381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcparadise
force-pushed
the
mp/remove-eol-ruby
branch
from
7fdf4b4
to
14709ff
Compare
vkarve-chef
approved these changes
Sep 19, 2022
marcparadise
force-pushed
the
mp/remove-eol-ruby
branch
from
14709ff
to
c69e8ca
Compare
jaymzh
approved these changes
Sep 20, 2022
marcparadise
force-pushed
the
mp/remove-eol-ruby
branch
from
c69e8ca
to
b5d0ac2
Compare
|
Note that windows build was failing prior to this PR, and is not addressed here. |
|
Kudos, SonarCloud Quality Gate passed!
|
|
Will update this further - even though we can't test these older versions, there may still be cases where they get pulled in and will work (like chef-install cookbook for upgrades). After update, it will leave in 'soft' support (conditional gems by version) but remove the unsupported ruby versions. |
jaymzh
added
the
Status: Waiting on Contributor
|
@marcparadise ping? :) |
Ruby 2.5 and earlier are all EOL and are no longer receiving security updates. Signed-off-by: Marc A. Paradise <marc.paradise@gmail.com>
pry-byebug is not supported on all platforms, and is also not necessary for running pipeline tests. Excluding gem group 'debug' from tests prevents failures related to unsupported platforms. Signed-off-by: Marc A. Paradise <marc.paradise@gmail.com> Signed-off-by: Thomas Powell <thomas.powell@progress.com>
tpowell-progress
force-pushed
the
mp/remove-eol-ruby
branch
from
b5d0ac2
to
5b35ff0
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ruby 2.5 and earlier are all EOL and are no longer receiving security updates.
Signed-off-by: Marc A. Paradise marc.paradise@gmail.com