Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEFAULT_READ_TIMEOUT should be exposed higher #89

Closed
sbcas opened this issue Feb 4, 2015 · 3 comments
Closed

DEFAULT_READ_TIMEOUT should be exposed higher #89

sbcas opened this issue Feb 4, 2015 · 3 comments

Comments

@sbcas
Copy link

sbcas commented Feb 4, 2015

Consider this a feature request. Currently, Mixlib::Shellout will kill a long running command after 600 seconds (see: https://github.com/chef/mixlib-shellout/blob/master/lib/mixlib/shellout.rb#L29).

In order to account for long running compiles during Chef runs or downloads, (vagrant box add, for example) it might make sense to expose DEFAULT_READ_TIMEOUT as an ENV variable so that the user can configure it to suit their needs without having to go hacking the gems that call shell_out().

@j4y
Copy link

j4y commented Feb 4, 2015

@sbcas
Copy link
Author

sbcas commented Feb 4, 2015

That's fine and all, but the end user shouldn't go hacking away at something like chef-provisioning-vagrant just to tell Mixlib::Shellout to knock it off.

I understand that it can be configured via shell_out(), but that's not what this is about. I shouldn't need to go changing shell_out() just so it doesn't kill an in-flight download or compile that takes 1200 seconds instead of 600 seconds.

@sbcas sbcas changed the title DEFAULT_READ_TIMEOUT should be configurable DEFAULT_READ_TIMEOUT should be exposed higher Feb 4, 2015
@lamont-granquist
Copy link
Contributor

chef-provisioning-vagrant needs to explicitly expose this as a tweakable.

@chef chef locked and limited conversation to collaborators Nov 16, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants