remove largely useless Utils class #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sooooo I'm actually using one of those :-/ https://github.com/poise/poise/blob/master/lib/poise/utils/win32.rb#L116 |
|
lol, 'k |
|
Works for me, I can switch over my code to do a feature detect on it easily enough so we can nuke the stub eventually. |
|
doesn't pass in your tests right now, i'm sure i've just got some thinko/typo somewhere... |
|
oic what the issue is... |
its just a collection of private methods, they should be private methods retain a method in the class that was being used externally. Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
lamont-granquist
force-pushed
the
lcg/cleanup1
branch
from
65a2ed1
to
5c13830
Compare
|
@coderanger fixed and squashed, passes your tests, can i get a 👍 ? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
its just a collection of private methods, they should be private methods