On windows, send sigkill to process if it exceeds its alloted time #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I haven't had any luck with the tests, but I'm 👍 on this change. Can you add a spec so we don't regress? |
|
Yeah spec and 👍 |
|
Code looks sane, would like a regression test. What we do for *nix is create a process that sleeps for a very long time (like 100s or more) and then set the timeout very low, like 1s, then check if the process exists after rescuing the timeout error. |
|
There's also some associated bugs in the chef repo about windows timeouts being ignored which can be closed after this is merged. |
Timeouts did not work correctly on windows because we do not kill or abandon the process. What was happening was a timeout condition was getting correctly detected, and an exception was being raised. However, before the exception could propogate, whatever the process was writing was fully read until it closed its FD.
jaym
force-pushed
the
jdm/win-kill-proc
branch
2 times, most recently
from
2fc9d56
to
ffec9cd
Compare
|
@tyler-ball @randomcamel @danielsdeleo Added a test |
jaym
force-pushed
the
jdm/win-kill-proc
branch
from
ffec9cd
to
4f425ea
Compare
|
👍 |
jaym
added a commit
that referenced
this pull request
Dec 18, 2014
On windows, send sigkill to process if it exceeds its alloted time
jaym
added a commit
that referenced
this pull request
Dec 19, 2014
On windows, send sigkill to process if it exceeds its alloted time
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Timeouts did not work correctly on windows because we do not kill or
abandon the process.
What was happening was a timeout condition was getting correctly detected,
and an exception was being raised. However, before the exception could
propagate, whatever the process was writing was fully read until it closed its FD.
@randomcamel said he was fixing up the tests
cc @btm @adamedx @randomcamel @opscode/client-engineers