Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get specs to pass on windows #81

Merged
merged 4 commits into from
Dec 18, 2014
Merged

Get specs to pass on windows #81

merged 4 commits into from
Dec 18, 2014

Conversation

jaym
Copy link
Contributor

@jaym jaym commented Dec 18, 2014

  • live_stream was broken on windows
  • A spec related to LC_ALL was broken. Looks like the behavior changed in 767ea4f and the Windows spec did not get updated to reflect that. @lamont-granquist can you please take a close look at 1132272 to make sure that was the intention

cc @opscode/client-engineers

@jaym
Fix live_stream for windows
8525785 
The windows module was looking to write stdout to live_stream
instead of live_stdout.
@jaym
The process no longer inherit LC_ALL from the parent. Update spec to …
1132272 
…refelect that.

This fixes a spec that was broken on Windows by 767ea4f
from PR #58

It seems the Unix spec was updated to reflect this change, but the Windows was not
@jaym
Added appveyor yaml
ebf3373
@jaym
Add ruby 2 to appveyor yaml
ddd69b6 
cleanup copy pasta errors
@randomcamel
Copy link

👍 pending @lamont-granquist confirming the new code behavior.

@lamont-granquist
Copy link
Contributor

Yep that's the intention. That's why we cut version 2.0.0

@danielsdeleo
Copy link
Contributor

💯 👍

jaym added a commit that referenced this pull request Dec 18, 2014
@jaym
Merge pull request #81 from opscode/jdm/test-fixes
f09d8a9 
Get specs to pass on windows
@jaym jaym merged commit f09d8a9 into master Dec 18, 2014
@jaym jaym deleted the jdm/test-fixes branch December 18, 2014 19:09
@adamedx
Copy link

adamedx commented Dec 18, 2014

nice work everyone, thank you for the fix @jdmundrawala.

@jaym jaym mentioned this pull request Dec 18, 2014
Closed
jaym added a commit that referenced this pull request Dec 19, 2014
@jaym
Merge pull request #81 from opscode/jdm/test-fixes
f84375a 
Get specs to pass on windows
@chef chef locked and limited conversation to collaborators Nov 16, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jaym @randomcamel @lamont-granquist @danielsdeleo @adamedx