Handle situations where /proc/cpuinfo lacks core data #1038
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This works around failures to collect core data on SLES <= 12 SP1. We need to support SLES and core counts are used in several of our product cookbooks. Signed-off-by: Tim Smith <tsmith@chef.io>
thommay
approved these changes
Jul 31, 2017
|
So I should add that this is technically a breaking change. When we ran on older systems previously we delivered completely bogus CPU info. Our tests even accounted for that. Now if we don't have count information we omit it vs. setting it to 0. The hope here is though that we run on these systems (like SLES) and fall back to lscpu, but if lscpu isn't there you're getting a missing value now. I think that's the right thing to do vs. falling back to 0s. |
tas50
changed the title
Signed-off-by: Tim Smith <tsmith@chef.io>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This works around failures to collect core data on SLES <= 12 SP1. We need to support SLES and core counts are used in several of our product cookbooks.
Signed-off-by: Tim Smith tsmith@chef.io