Add plugin timing information in debug mode #1056
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A reoccurring problem in Ohai is the runs taking too long. It's hard to troubleshoot since you can't tell what plugin is causing the long runs. This simple debug information provides us with the information we need to troubleshoot unusually long ohai run times. Example output ``` [2017-09-11T09:20:27-07:00] DEBUG: Plugin Ruby took 1.568772 seconds to run. [2017-09-11T09:20:27-07:00] DEBUG: Plugin Rust: ran 'rustc --version' and returned 0 [2017-09-11T09:20:27-07:00] DEBUG: Plugin Rust took 0.356488 seconds to run. [2017-09-11T09:20:31-07:00] DEBUG: Plugin Scala: ran 'scala -version' and returned 0 [2017-09-11T09:20:31-07:00] DEBUG: Plugin Scala took 3.216373 seconds to run. [2017-09-11T09:20:36-07:00] DEBUG: Ohai took 16.940469 total seconds to run. ``` Signed-off-by: Tim Smith <tsmith@chef.io>
|
I'd be tempted to use Benchmark.measure (https://ruby-doc.org/stdlib-2.4.0/libdoc/benchmark/rdoc/Benchmark.html#method-c-measure) rather than manual Times. |
Seems like a bit of overkill, but it does nicely format the time strings, which I'll take Signed-off-by: Tim Smith <tsmith@chef.io>
|
@thommay I updated it with Benchmark. I'll take sane time notation. |
cheeseplus
approved these changes
Sep 19, 2017
lamont-granquist
approved these changes
Sep 19, 2017
|
👍 on Benchmark.measure code looks entirely correct. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A reoccurring problem in Ohai is the runs taking too long. It's hard to troubleshoot since you can't tell what plugin is causing the long runs. This simple debug information provides us with the information we need to troubleshoot unusually long ohai run times.
Example output
Signed-off-by: Tim Smith tsmith@chef.io