Support optional plugins #1136
Merged
Support optional plugins #1136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some plugins are useful enough to ship in Ohai, but should be off by default. Those plugins can be (and are) marked as optional. Implements RFC 103 Signed-off-by: Thom May <thom@chef.io>
tas50
reviewed
Feb 16, 2018
| @@ -32,15 +32,8 @@ def self.valid_name?(name) | |||
| name.is_a?(Symbol) && name.to_s.match(/^[^A-Z]|_/).nil? | |||
| end | |||
|
|
|||
| # dealing with ruby 1.8 | |||
|
Looks pretty straight forward. Lets just make sure we get this added to the Ohai plugin docs so people know the new DSL exists. |
tas50
approved these changes
Feb 16, 2018
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some plugins are useful enough to ship in Ohai, but should be off by
default. Those plugins can be (and are) marked as optional. Implements
RFC 103