Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand what we blacklist from the kernel/network plugins on Windows #1147

Merged
merged 2 commits into from
Feb 28, 2018

Conversation

tas50
Copy link
Contributor

@tas50 tas50 commented Feb 28, 2018

We're collecting some super useless data here (wmi class names) and some entirely duplicate data. Lets shave a tiny bit of storage space off the node object and make it easier to reason with.

This reduces the uncompressed node object by 1k

Signed-off-by: Tim Smith tsmith@chef.io

@tas50 tas50 requested a review from a team February 28, 2018 18:53
We're collecting some super useless data here (wmi class names) and some entirely duplicate data. Lets shave a tiny bit of storage space off the node object and make it easier to reason with.

Signed-off-by: Tim Smith <tsmith@chef.io>
Another .2k on a standard node

Signed-off-by: Tim Smith <tsmith@chef.io>
@tas50 tas50 changed the title Expand what we blacklist from the kernel plugin on Windows Expand what we blacklist from the kernel/network plugins on Windows Feb 28, 2018
@tas50 tas50 merged commit 1ab1078 into master Feb 28, 2018
@tas50 tas50 deleted the tidy_up branch February 28, 2018 22:24
@lock
Copy link

lock bot commented Jan 25, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants