[filesystem] Unify plugins, bring BSD into the modern age #1181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We never converted anything other than mac or linux because we're clowny, and now BSD and other Unixes has a totally different API than Mac and Linux. This creates a single plugin so they can leverage the helper classes, and moves mac, linux and BSD into it, and adds full support for BSD. This starts to fix chef#1180 Signed-off-by: Phil Dibowitz <phil@ipom.com>
|
I didn't do release notes because it's no longer ordered by release and so I don't know how... |
|
Fixing lint... |
jaymzh
added a commit
to jaymzh/ohai
that referenced
this pull request
May 4, 2018
This is partial backport of chef#1181. Rather than do the merging it simply makes an additional plugin to be as non-intrusive to 13 as possible, but to provide some level of upgradability to those who need it. Signed-off-by: Phil Dibowitz <phil@ipom.com>
4 tasks
|
I'd honestly rather have kept them as separate files but I'm not sure it really matters. Thanks for updating BSD |
thommay
approved these changes
May 10, 2018
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We never converted anything other than mac or linux because we're clowny, and
now BSD and other Unixes has a totally different API than Mac and Linux.
This creates a single plugin so they can leverage the helper classes, and moves
mac, linux and BSD into it, and adds full support for BSD.
This starts to fix #1180
Signed-off-by: Phil Dibowitz phil@ipom.com
Check List