Trim out bogus data in system_profile plugin #1263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also there's no need to rescue requiring plist since ohai depends on it. We don't do this for anything else in Ohai. Signed-off-by: Tim Smith <tsmith@chef.io>
|
This looks good to me! |
jaymzh
approved these changes
Oct 10, 2018
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also there's no need to rescue requiring plist since ohai depends on it. We don't do this for anything else in Ohai. This shaves 8k from the node data. I'm also going to open a PR to deprecate this plugin so we can remove it in Chef 15 since it doesn't actually work on modern systems and we already collect the same data in the hardware plugin.
Signed-off-by: Tim Smith tsmith@chef.io