Deprecate the system_profile plugin #1264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1) It's broken 2) It's a huge amount of data on the node 3) It takes 3 seconds to run 4) Hardware plugin does the same thing, but better Signed-off-by: Tim Smith <tsmith@chef.io>
|
Hey @mikedodge04 - I'm pretty sure we're OK with this - you've replaced this functionality in other ohai plugins but can you just confirm? |
kagarmoe
approved these changes
Oct 10, 2018
|
Burn it with fire. We can already get this data from other sources as Phil said. |
|
I'm in agreement. Lets kill it ! |
|
Thanks for the comments everyone. Faster mac ohai runs here we come. |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Tim Smith tsmith@chef.io