Back out SLES -> SUSE remapping and instead fix the platform_family #1322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think this was actually the wrong thing to do. We previously detected it as SLED and I think that's actually the right call. Signed-off-by: Tim Smith <tsmith@chef.io>
SUSE Linux Enterprise Desktop is SLES with a UI. It's SUSE platform_family. Signed-off-by: Tim Smith <tsmith@chef.io>
lamont-granquist
approved these changes
Dec 5, 2018
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After thinking about this remapping SLED to SUSE was wrong. People would want a way to identify SLED and distinguish it from the server variety. This backs out the previous change and instead adds SLED to the suse platform_family.