Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ohai::Util::FileHelper does not need to be loaded in this systemd_paths plugin #1347

Merged
merged 1 commit into from
Apr 10, 2019
Merged

Ohai::Util::FileHelper does not need to be loaded in this systemd_paths plugin #1347

merged 1 commit into from
Apr 10, 2019

Conversation

burtlo
Copy link

@burtlo burtlo commented Apr 4, 2019

Description

This module is already in the mix.

Signed-off-by: Franklin Webber franklin.webber@gmail.com

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have read the CONTRIBUTING document.
  • I have run the pre-merge tests locally and they pass.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • All commits have been signed-off for the Developer Certificate of Origin.

Ohai::Util::FileHelper is already loaded
bf88c7e 
This module is already in the mix.

Signed-off-by: Franklin Webber <franklin.webber@gmail.com>
@burtlo burtlo requested a review from a team April 4, 2019 05:13
@tas50
Copy link
Contributor

tas50 commented Apr 10, 2019

Thanks!

@tas50 tas50 merged commit 8d13e27 into chef:master Apr 10, 2019
@lock
Copy link

lock bot commented Jun 9, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tas50 tas50 tas50 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@burtlo @tas50