Add logic to fetch the latest azure metadata version #1427

tas50 · 2020-01-30T03:30:01Z

This is inspired by the way we do this in EC2, but it's different in
many ways since Azure presents the latest version in a different way.

Additional values exposed by this:

      "azEnvironment": "AzurePublicCloud",
      "customData": "",
      "plan": {
        "name": "",
        "product": "",
        "publisher": ""
      },
      "provider": "Microsoft.Compute",
      "publicKeys": [
        {
          "keyData": "ssh-rsa 123",
          "path": "/home/tsmith/.ssh/authorized_keys"
        }
      ],
      "resourceId": "/subscriptions/123/resourceGroups/tsmith/providers/Microsoft.Compute/virtualMachines/timtest",
    "storageProfile": {
        "dataDisks": [

        ],
        "imageReference": {
          "id": "",
          "offer": "UbuntuServer",
          "publisher": "Canonical",
          "sku": "18.04-LTS",
          "version": "latest"
        },
        "osDisk": {
          "caching": "ReadWrite",
          "createOption": "FromImage",
          "diffDiskSettings": {
            "option": ""
          },
          "diskSizeGB": "30",
          "encryptionSettings": {
            "enabled": "false"
          },
          "image": {
            "uri": ""
          },
          "managedDisk": {
            "id": "/subscriptions/123/resourceGroups/tsmith/providers/Microsoft.Compute/disks/timtest_OsDisk_1_f68c8aee869f4668aff1f12e449be5ac",
            "storageAccountType": "Premium_LRS"
          },
          "name": "timtest_OsDisk_1_f68c8aee869f4668aff1f12e449be5ac",
          "osType": "Linux",
          "vhd": {
            "uri": ""
          },
          "writeAcceleratorEnabled": "false"
        }
      },
      "tagsList": [

      ],
      "vmScaleSetName": "",
      "zone": ""

Signed-off-by: Tim Smith tsmith@chef.io

This is inspired by the way we do this in EC2, but it's different in many ways since Azure presents the latest version in a different way. Signed-off-by: Tim Smith <tsmith@chef.io>

lib/ohai/mixin/azure_metadata.rb

From review Signed-off-by: Tim Smith <tsmith@chef.io>

lib/ohai/mixin/azure_metadata.rb

This way it doesn't blow up if azure changes the response Signed-off-by: Tim Smith <tsmith@chef.io>

lib/ohai/mixin/azure_metadata.rb

phiggins · 2020-03-03T20:53:36Z

lib/ohai/mixin/azure_metadata.rb

+            logger.trace("Mixin AzureMetadata: Received HTTP 404 from metadata server while determining API version, assuming #{AZURE_SUPPORTED_VERSIONS.last}")
+            return AZURE_SUPPORTED_VERSIONS.last
+          elsif response.code != "400" # 400 is actually what we want
+            raise "Mixin AzureMetadata: Unable to determine Azure metadata version (returned #{response.code} response)"


I'm really unfamiliar with the conventions of this project, but should this return a specific error type rather than the generic error?

Most places in Ohai are just generic errors

phiggins

I had some code-style suggestions but overall this is good 👍

Updates from review Signed-off-by: Tim Smith <tsmith@chef.io>

No need for this Signed-off-by: Tim Smith <tsmith@chef.io>

tas50 mentioned this pull request Jan 30, 2020

Use similar logic in Azure that we use in EC2 for finding the best metadata endpoint #1159

Closed

tas50 force-pushed the new_azure_versions branch from 708e4bf to 3a5ceb4 Compare February 20, 2020 01:15

tas50 requested a review from a team as a code owner February 20, 2020 01:15

tas50 force-pushed the new_azure_versions branch from 3a5ceb4 to 9930e8c Compare February 28, 2020 17:36

Support fetching the latest version of Azure metadata

808ce32

This is inspired by the way we do this in EC2, but it's different in many ways since Azure presents the latest version in a different way. Signed-off-by: Tim Smith <tsmith@chef.io>

tas50 force-pushed the new_azure_versions branch from 9930e8c to 808ce32 Compare March 2, 2020 20:44

tas50 changed the title ~~WIP: Add logic to fetch the latest azure metadata version~~ Add logic to fetch the latest azure metadata version Mar 2, 2020