Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use correct DMI attribute name for product name #1451

Merged
merged 2 commits into from
Apr 20, 2020

Conversation

ramereth
Copy link
Contributor

I discovered that ohai was incorrectly detecting our OpenStack guests showing
the following output:

{
  "systems": {

  }
}

With this change, it correctly shows the following output:

{
  "systems": {
    "openstack": "guest"
  },
  "system": "openstack",
  "role": "guest"
}

The problem was the fact that dmi/system/product was the incorrect attribute and
should be dmi/system/product_name instead.

Signed-off-by: Lance Albertson lance@osuosl.org

Description

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

  • I have read the CONTRIBUTING document.
  • I have run the pre-merge tests locally and they pass.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • All commits have been signed-off for the Developer Certificate of Origin.

I discovered that ohai was incorrectly detecting our OpenStack guests showing
the following output:

{
  "systems": {

  }
}

With this change, it correctly shows the following output:

{
  "systems": {
    "openstack": "guest"
  },
  "system": "openstack",
  "role": "guest"
}

The problem was the fact that dmi/system/product was the incorrect attribute and
should be dmi/system/product_name instead.

Signed-off-by: Lance Albertson <lance@osuosl.org>
@ramereth ramereth requested review from a team as code owners April 17, 2020 21:51
The `Layout/Tab` cop has been renamed to `Layout/IndentationStyle`

Signed-off-by: Lance Albertson <lance@osuosl.org>
@tas50 tas50 merged commit a0966c5 into chef:master Apr 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants